Skip to content

docs: remove Node.js 12 deprecation notice from docs #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

With v1.5.1 released support for Node.js 12 has ended, so we can remove the deprecation notice that was at the top of the documentation.

Fixes #1236

How to verify this change

See updated docs.

Related issues, RFCs

Issue number: #1236

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Jan 13, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 13, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 13, 2023
@dreamorosi dreamorosi merged commit 3620bb2 into main Jan 13, 2023
@dreamorosi dreamorosi deleted the docs/remove_deprecation_notice branch January 13, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: remove Node.js 12 deprecation notice
1 participant